linux-kernel - Re: [PATCH v3 0/3] Additional miscdevice fops parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2AY8D3pni7wxWD1@cassiopeiae>
Date: Mon, 16 Dec 2024 13:11:28 +0100
From: Danilo Krummrich <dakr@...nel.org>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
	Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Trevor Gross <tmgross@...ch.edu>, Lee Jones <lee@...nel.org>,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v3 0/3] Additional miscdevice fops parameters

On Tue, Dec 10, 2024 at 09:38:59AM +0000, Alice Ryhl wrote:
> This could not land with the base miscdevice abstractions due to the
> dependency on File.
> 
> The last two patches enable you to use the `dev_*` macros to print
> messages in miscdevice drivers.
> 
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

For the series,

Reviewed-by: Danilo Krummrich <dakr@...nel.org>

> ---
> Changes in v3:
> - Fix build error in fops->open() patch.
> - Improve wording of some comments in fops->open() patch.
> - Update commit message with more info on why `struct miscdevice` is
>   only made available in fops->open() and not other hooks.
> - Include Lee's device accessor patch, since it's a needed component to
>   use the `dev_*` printing macros with miscdevice.
> - Link to v2: https://lore.kernel.org/r/20241209-miscdevice-file-param-v2-0-83ece27e9ff6@google.com
> 
> Changes in v2:
> - Access the `struct miscdevice` from fops->open().
> - Link to v1: https://lore.kernel.org/r/20241203-miscdevice-file-param-v1-1-1d6622978480@google.com
> 
> ---
> Alice Ryhl (2):
>       rust: miscdevice: access file in fops
>       rust: miscdevice: access the `struct miscdevice` from fops->open()
> 
> Lee Jones (1):
>       rust: miscdevice: Provide accessor to pull out miscdevice::this_device
> 
>  rust/kernel/miscdevice.rs | 66 +++++++++++++++++++++++++++++++++++++++--------
>  1 file changed, 55 insertions(+), 11 deletions(-)
> ---
> base-commit: fac04efc5c793dccbd07e2d59af9f90b7fc0dca4
> change-id: 20241203-miscdevice-file-param-5df7f75861da
> 
> Best regards,
> -- 
> Alice Ryhl <aliceryhl@...gle.com>
> 
>