linux-kernel - Re: [PATCH] [v2] firmware: cs_dsp: avoid large local variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1bf6353-1aa8-4457-8d4a-09b7e9aec97a@opensource.cirrus.com>
Date: Mon, 16 Dec 2024 12:39:44 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Arnd Bergmann <arnd@...nel.org>,
        Simon Trimmer
	<simont@...nsource.cirrus.com>,
        Charles Keepax
	<ckeepax@...nsource.cirrus.com>,
        Mark Brown <broonie@...nel.org>
CC: Arnd Bergmann <arnd@...db.de>, <patches@...nsource.cirrus.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [v2] firmware: cs_dsp: avoid large local variables

On 16/12/2024 12:15 pm, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Having 1280 bytes of local variables on the stack exceeds the limit
> on 32-bit architectures:
> 
> drivers/firmware/cirrus/test/cs_dsp_test_bin.c: In function 'bin_patch_mixed_packed_unpacked_random':
> drivers/firmware/cirrus/test/cs_dsp_test_bin.c:2097:1: error: the frame size of 1784 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
> 
> Use dynamic allocation for the largest two here.
> 
> Fixes: dd0b6b1f29b9 ("firmware: cs_dsp: Add KUnit testing of bin file download")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> v2 changes:
>   - use kunit_kmalloc() as suggested by Richard Fitzgerald
>   - use KUNIT_ASSERT_NOT_NULL
> ---
>   .../firmware/cirrus/test/cs_dsp_test_bin.c    | 33 +++++++++++--------
>   1 file changed, 19 insertions(+), 14 deletions(-)
> 
Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>

Thanks for doing this.