linux-kernel - Re: [PATCH net-next v1 2/6] net: usb: lan78xx: Use ETIMEDOUT instead of ETIME in lan78xx_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <029000b1-ad0b-4632-9700-85d55b80053a@intel.com>
Date: Mon, 16 Dec 2024 14:08:37 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Woojung Huh
	<woojung.huh@...rochip.com>, Andrew Lunn <andrew+netdev@...n.ch>
CC: <kernel@...gutronix.de>, <linux-kernel@...r.kernel.org>,
	<netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>, Phil Elwell
	<phil@...pberrypi.org>
Subject: Re: [PATCH net-next v1 2/6] net: usb: lan78xx: Use ETIMEDOUT instead
 of ETIME in lan78xx_stop_hw



On 12/16/2024 1:09 PM, Oleksij Rempel wrote:
> Update lan78xx_stop_hw to return -ETIMEDOUT instead of -ETIME when
> a timeout occurs. While -ETIME indicates a general timer expiration,
> -ETIMEDOUT is more commonly used for signaling operation timeouts and
> provides better consistency with standard error handling in the driver.
> 
> The -ETIME checks in tx_complete() and rx_complete() are unrelated to
> this error handling change. In these functions, the error values are derived
> from urb->status, which reflects USB transfer errors. The error value from
> lan78xx_stop_hw will be exposed in the following cases:
> - usb_driver::suspend
> - net_device_ops::ndo_stop (potentially, though currently the return value
>    is not used).
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>   drivers/net/usb/lan78xx.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 270345fcad65..4674051f5c9c 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -844,9 +844,7 @@ static int lan78xx_stop_hw(struct lan78xx_net *dev, u32 reg, u32 hw_enabled,
>   		} while (!stopped && !time_after(jiffies, timeout));
>   	}
>   
> -	ret = stopped ? 0 : -ETIME;
> -
> -	return ret;
> +	return stopped ? 0 : -ETIMEDOUT;
>   }
>   
>   static int lan78xx_flush_fifo(struct lan78xx_net *dev, u32 reg, u32 fifo_flush)

This looks good, nice cleanup.

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>