linux-kernel - Re: [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to lan78xx_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2Ao8r3gJRnQLq_I@pengutronix.de>
Date: Mon, 16 Dec 2024 14:19:46 +0100
From: Oleksij Rempel <o.rempel@...gutronix.de>
To: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com, Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH net-next v1 1/6] net: usb: lan78xx: Add error handling to
 lan78xx_get_regs

On Mon, Dec 16, 2024 at 02:07:37PM +0100, Mateusz Polchlopek wrote:
> 
> 
> On 12/16/2024 1:09 PM, Oleksij Rempel wrote:
> >   	if (!netdev->phydev)
> >   		return;
> >   	/* Read PHY registers */
> > -	for (j = 0; j < 32; i++, j++)
> > -		data[i] = phy_read(netdev->phydev, j);
> > +	for (j = 0; j < 32; i++, j++) {
> 
> Maybe during this refactor is it worth to add some #define with
> number of registers to be read?

I prefer to remove this part. Please see patch 5

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |