linux-kernel - Re: [GIT PULL] ftrace: Fixes for v6.13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241216083324.5b2677f4@gandalf.local.home>
Date: Mon, 16 Dec 2024 08:33:24 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu
 <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Al Viro
 <viro@...iv.linux.org.uk>, Michal Simek <monstr@...str.eu>
Subject: Re: [GIT PULL] ftrace: Fixes for v6.13

On Sun, 15 Dec 2024 20:24:04 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> > Isn't every single case of '%p' in this context from a TP_printk() situation?
> > 
> > IOW, instead of dynamically creating a temporary buffer and adding
> > that 'x' by hand, why wasn't that just a 'sed' script and done
> > statically?
> > 
> > In fact, wouldn't *most* of the sanity checking be possible to just do
> > entirely statically instead of at runtime?
> > 
> > Yeah, yeah, there's more than a few '%p' users, but
> > 
> >      git grep 'TP_printk.*%p[^A-Za-z]' | wc
> > 
> > shows that it's manageable. That probably misses some multi-line
> > cases, but still - doing this kind of "rewrite constant string at
> > runtime because we didn't do it statically" seems *wrong*.
> > 
> > And in this case, that wrongness was literally the cause of the bug.  
> 
> I'm also OK with that. Should that be done for 6.13 or something to be
> added for 6.14?

One issue with just doing it manually, is that it would need to be
maintained, as one or two "%p" are added per release cycle.

-- Steve