linux-kernel - Re: [PATCH v2.1] x86/amd_node, platform/x86/amd/hsmp: Have HSMP use SMN through AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff59d4e9-15da-37b3-1a8c-1ae688fa4094@linux.intel.com>
Date: Mon, 16 Dec 2024 15:57:23 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Yazen Ghannam <yazen.ghannam@....com>
cc: x86@...nel.org, tony.luck@...el.com, mario.limonciello@....com, 
    bhelgaas@...gle.com, jdelvare@...e.com, linux@...ck-us.net, 
    clemens@...isch.de, Shyam-sundar.S-k@....com, 
    Hans de Goede <hdegoede@...hat.com>, naveenkrishna.chatradhi@....com, 
    suma.hegde@....com, LKML <linux-kernel@...r.kernel.org>, 
    linux-edac@...r.kernel.org, linux-pci@...r.kernel.org, 
    linux-hwmon@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH v2.1] x86/amd_node, platform/x86/amd/hsmp: Have HSMP use
 SMN through AMD_NODE

On Thu, 12 Dec 2024, Yazen Ghannam wrote:

> On Thu, Dec 12, 2024 at 08:50:26PM +0200, Ilpo Järvinen wrote:
> > On Thu, 12 Dec 2024, Yazen Ghannam wrote:
> > > @@ -95,7 +80,12 @@ static umode_t hsmp_is_sock_attr_visible(struct kobject *kobj,
> > >   * Static array of 8 + 1(for NULL) elements is created below
> > >   * to create sysfs groups for sockets.
> > >   * is_bin_visible function is used to show / hide the necessary groups.
> > > + *
> > > + * Validate the maximum number against MAX_AMD_NUM_NODES. If this changes,
> > > + * then the attributes and groups below must be adjusted.
> > >   */
> > > +static_assert(MAX_AMD_NUM_NODES == 8);
> > 
> > Please also add the #include for it.
> >
> 
> Just to confirm, you mean for static_assert()?
> 
>   #include <linux/build_bug.h>

I saw you already made that change but yes, it is what I meant.

-- 
 i.