linux-kernel - Re: [PATCH] usb: phy-tahvo: fix call balance for tu->ick handling routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0a4227dd3582ddd4da13d152ab20854e@ispras.ru>
Date: Mon, 16 Dec 2024 14:07:03 +0000
From: mordan@...ras.ru
To: "Dan Carpenter" <dan.carpenter@...aro.org>, oe-kbuild@...ts.linux.dev,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev,
 "Uwe Kleine-König" <u.kleine-koenig@...libre.com>,
 "Aaro Koskinen" <aaro.koskinen@....fi>, "Felipe Balbi"
 <felipe.balbi@...ux.intel.com>, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org, "Fedor Pchelkin" <pchelkin@...ras.ru>,
 "Alexey Khoroshilov" <khoroshilov@...ras.ru>, "Vadim Mutilin"
 <mutilin@...ras.ru>, stable@...r.kernel.org
Subject: Re: [PATCH] usb: phy-tahvo: fix call balance for tu->ick handling
 routines

Thank you very much for reporting this issue. I will fix it in patch v2.
Thanks, Vitalii


December 16, 2024 2:53 AM, "Dan Carpenter" <dan.carpenter@...aro.org> wrote:

> Hi Vitalii,
> 
> kernel test robot noticed the following build warnings:
> 
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:
> https://github.com/intel-lab-lkp/linux/commits/Vitalii-Mordan/usb-phy-tahvo-fix-call-balance-for-tu-
> ck-handling-routines/20241209-232934
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> patch link: https://lore.kernel.org/r/20241209152604.1918882-1-mordan@ispras.ru
> patch subject: [PATCH] usb: phy-tahvo: fix call balance for tu->ick handling routines
> config: alpha-randconfig-r072-20241215
> (https://download.01.org/0day-ci/archive/20241215/202412150530.f03D8q1a-lkp@intel.com/config)
> compiler: alpha-linux-gcc (GCC) 14.2.0
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> | Closes: https://lore.kernel.org/r/202412150530.f03D8q1a-lkp@intel.com
> 
> smatch warnings:
> drivers/usb/phy/phy-tahvo.c:347 tahvo_usb_probe() warn: passing zero to 'PTR_ERR'
> 
> vim +/PTR_ERR +347 drivers/usb/phy/phy-tahvo.c
> 
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 341
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 342 mutex_init(&tu->serialize);
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 343
> 125b175df62ecc Vitalii Mordan 2024-12-09 344 tu->ick = devm_clk_get_enabled(&pdev->dev,
> "usb_l4_ick");
> 125b175df62ecc Vitalii Mordan 2024-12-09 345 if (!IS_ERR(tu->ick)) {
> ^
> This typo breaks the driver.
> 
> 125b175df62ecc Vitalii Mordan 2024-12-09 346 dev_err(&pdev->dev, "failed to get and enable
> clock\n");
> 125b175df62ecc Vitalii Mordan 2024-12-09 @347 return PTR_ERR(tu->ick);
> 125b175df62ecc Vitalii Mordan 2024-12-09 348 }
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 349
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 350 /*
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 351 * Set initial state, so that we generate kevents only
> on state changes.
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 352 */
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 353 tu->vbus_state = retu_read(rdev, TAHVO_REG_IDSR) &
> TAHVO_STAT_VBUS;
> 9ba96ae5074c9f Aaro Koskinen 2013-12-06 354
> 860d2686fda7e4 Chanwoo Choi 2015-07-01 355 tu->extcon = devm_extcon_dev_allocate(&pdev->dev,
> tahvo_cable);
> 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki