linux-kernel - Re: [PATCH v2 0/5] Move kvfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d352db4f-4bb8-4300-b235-bbd1bdb3aa21@suse.cz>
Date: Mon, 16 Dec 2024 15:20:44 +0100
From: Vlastimil Babka <vbabka@...e.cz>
To: Uladzislau Rezki <urezki@...il.com>
Cc: linux-mm@...ck.org, "Paul E . McKenney" <paulmck@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>, RCU <rcu@...r.kernel.org>,
 LKML <linux-kernel@...r.kernel.org>, Christoph Lameter <cl@...ux.com>,
 Pekka Enberg <penberg@...nel.org>, David Rientjes <rientjes@...gle.com>,
 Joonsoo Kim <iamjoonsoo.kim@....com>,
 Roman Gushchin <roman.gushchin@...ux.dev>,
 Hyeonggon Yoo <42.hyeyoo@...il.com>,
 Oleksiy Avramchenko <oleksiy.avramchenko@...y.com>
Subject: Re: [PATCH v2 0/5] Move kvfree_rcu() into SLAB (v2)

On 12/16/24 12:03, Uladzislau Rezki wrote:
> On Sun, Dec 15, 2024 at 06:30:02PM +0100, Vlastimil Babka wrote:
>> On 12/12/24 19:02, Uladzislau Rezki (Sony) wrote:
>> > Hello!
>> > 
>> > This is v2. It is based on the Linux 6.13-rc2. The first version is
>> > here:
>> > 
>> > https://lore.kernel.org/linux-mm/20241210164035.3391747-4-urezki@gmail.com/T/
>> > 
>> > The difference between v1 and v2 is that, the preparation process is
>> > done in original place instead and after that there is one final move.
>> 
>> Looks good, will include in slab/for-next
>> 
>> I think patch 5 should add more explanation to the commit message - the
>> subthread started by Christoph could provide content :) Can you summarize so
>> I can amend the commit log?
>> 
> I will :)
> 
>> Also how about a followup patch moving the rcu-tiny implementation of
>> kvfree_call_rcu()?
>> 
> As, Paul already noted, it would make sense. Or just remove a tiny
> implementation.

AFAICS tiny rcu is for !SMP systems. Do they benefit from the "full"
implementation with all the batching etc or would that be unnecessary overhead?

>>
>> We might also consider moving the kfree_rcu*() entry points from rcupdate.h
>> to slab.h, what do you think, is it a more logical place for them? There's
>> some risk that files that include rcupdate.h and not slab.h would break, so
>> that will need some build testing...
>> 
> I agree. I have not moved them in this series, because it requires more
> testing due to a build break. I can work on this further, so it is not
> an issue.
> 
> Thank you for taking this!
> 
> --
> Uladzislau Rezki