linux-kernel - Re: [RFC PATCH 06/22] selinux: rename comparison functions for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f00152c1-6eb9-487d-af69-42573b5f79bc@linux.microsoft.com>
Date: Mon, 16 Dec 2024 09:28:10 -0500
From: Daniel Burgener <dburgener@...ux.microsoft.com>
To: cgzones@...glemail.com, selinux@...r.kernel.org
Cc: Paul Moore <paul@...l-moore.com>,
 Stephen Smalley <stephen.smalley.work@...il.com>,
 Ondrej Mosnacek <omosnace@...hat.com>,
 John Johansen <john.johansen@...onical.com>,
 Casey Schaufler <casey@...aufler-ca.com>,
 Thiébaud Weksteen <tweek@...gle.com>,
 Canfeng Guo <guocanfeng@...ontech.com>, GUO Zihua <guozihua@...wei.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 06/22] selinux: rename comparison functions for
 clarity

On 11/15/2024 8:35 AM, Christian Göttsche wrote:
> From: Christian Göttsche <cgzones@...glemail.com>
> 
> The functions context_cmp() and mls_context_cmp() are not traditional
> C style compare functions returning -1, 0, and 1 for less than, equal,
> and greater than; they only return whether their arguments are equal.
> 
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
>   security/selinux/ss/context.c  |  2 +-
>   security/selinux/ss/context.h  | 10 +++++-----
>   security/selinux/ss/services.c |  2 +-
>   security/selinux/ss/sidtab.c   |  2 +-
>   4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/security/selinux/ss/context.c b/security/selinux/ss/context.c
> index e39990f494dd..a528b7f76280 100644
> --- a/security/selinux/ss/context.c
> +++ b/security/selinux/ss/context.c
> @@ -20,7 +20,7 @@ u32 context_compute_hash(const struct context *c)
>   	 * context struct with only the len & str set (and vice versa)
>   	 * under a given policy. Since context structs from different
>   	 * policies should never meet, it is safe to hash valid and
> -	 * invalid contexts differently. The context_cmp() function
> +	 * invalid contexts differently. The context_equal() function
>   	 * already operates under the same assumption.
>   	 */
>   	if (c->len)
> diff --git a/security/selinux/ss/context.h b/security/selinux/ss/context.h
> index 7ccab2e6965f..e1307f6f7f50 100644
> --- a/security/selinux/ss/context.h
> +++ b/security/selinux/ss/context.h
> @@ -132,8 +132,8 @@ static inline int mls_context_glblub(struct context *dst,
>   	return rc;
>   }
>   
> -static inline int mls_context_cmp(const struct context *c1,
> -				  const struct context *c2)
> +static inline bool mls_context_equal(const struct context *c1,
> +				     const struct context *c2)
>   {
>   	return ((c1->range.level[0].sens == c2->range.level[0].sens) &&
>   		ebitmap_cmp(&c1->range.level[0].cat, &c2->range.level[0].cat) &&

Should the same logic in this patch be applied to ebitmap_cmp as well?

-Daniel