linux-kernel - Re: [PATCH] ALSA: compress_offload: Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA+D8AO09ER29upoNfv4uUw_D6vPcQ-XBkzTjv2QqxpK52oHdA@mail.gmail.com>
Date: Mon, 16 Dec 2024 11:09:08 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: vkoul@...nel.org, perex@...ex.cz, tiwai@...e.com, 
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, broonie@...nel.org, 
	lgirdwood@...il.com
Subject: Re: [PATCH] ALSA: compress_offload: Fix get_user usage

On Mon, Dec 16, 2024 at 10:32 AM Shengjiu Wang <shengjiu.wang@....com> wrote:
>
> ERROR: modpost: "__get_user_bad" [sound/core/snd-compress.ko] undefined!
>
> Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202412141955.FBjr5T5q-lkp@intel.com/
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---
>  sound/core/compress_offload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 6f2d389abd04..dadf074359ec 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -1182,7 +1182,7 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg
>
>         if (stream->runtime->state != SNDRV_PCM_STATE_SETUP)
>                 return -EPERM;
> -       retval = get_user(seqno, (__u64 __user *)arg);
> +       retval = get_user(seqno, (__u32 __user *)arg);

This change may not be accurate. Do we have get_user() for 64bit?

Best regards
Shengjiu Wang

>         if (retval < 0)
>                 return retval;
>         retval = 0;
> --
> 2.37.1
>
>