[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87h673zkhr.fsf_-_@email.froward.int.ebiederm.org>
Date: Mon, 16 Dec 2024 10:00:00 -0600
From: "Eric W. Biederman" <ebiederm@...ssion.com>
To: David Woodhouse <dwmw2@...radead.org>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Thomas Gleixner <tglx@...utronix.de>, Ming Lei <ming.lei@...hat.com>,
LKML <linux-kernel@...r.kernel.org>,
Linux PM <linux-pm@...r.kernel.org>,
Kexec Mailing List <kexec@...ts.infradead.org>
Subject: Does anyone actually use KEXEC_JUMP?
David Woodhouse <dwmw2@...radead.org> writes:
> On Mon, 2024-12-16 at 14:39 +0100, Rafael J. Wysocki wrote:
>> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>>
>> The KEXEC_JUMP flow is analogous to hibernation flows occurring
>> before
>> and after creating an image and before and after jumping from the
>> restore kernel to the image one, which is why it uses the same device
>> callbacks as those hibernation flows.
>>
>> Add comments explaining that to the code in question and update an
>> existing comment in it which appears a bit out of context.
>>
>> No functional changes.
>>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Thanks. I'll round that up into my kexec-debug tree, which Ingo has
> been taking into tip/x86/boot. Once I'm done fighting with
> objtool(qv).
I have no objection to getting kexec jump more in sync with the
rest of the power management code.
I do have a question though. Does anyone actually use kexec jump?
It is fine if folks do, but I haven't actually heard of anyone using
it. If folks aren't using it, it might make sense to just use the fact
that it is broken as a nudge to remove that option.
Eric
Powered by blists - more mailing lists