linux-kernel - Re: [PATCH v10 2/4] media: qcom: camss: update clock names for sc7280

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae6db654-c19a-4fde-a649-48c63f4e6394@kernel.org>
Date: Tue, 17 Dec 2024 15:11:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vikram Sharma <quic_vikramsa@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org, mchehab@...nel.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 akapatra@...cinc.com, hariramp@...cinc.com, andersson@...nel.org,
 konradybcio@...nel.org, hverkuil-cisco@...all.nl,
 cros-qcom-dts-watchers@...omium.org, catalin.marinas@....com, will@...nel.org
Cc: linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...cinc.com
Subject: Re: [PATCH v10 2/4] media: qcom: camss: update clock names for sc7280

On 17/12/2024 15:06, Vikram Sharma wrote:
> This patch changes gcc_cam_hf_axi clock name to make consistent

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

> with existing platforms and add gcc_axi_sf clock too.
> gcc_cam_hf_axi changed to gcc_axi_hf.
> added gcc_axi_sf.

Explain ABI impact and don't mix new features with some sort of refactoring.

> 
> Signed-off-by: Vikram Sharma <quic_vikramsa@...cinc.com>
> ---
>  drivers/media/platform/qcom/camss/camss.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 004a74f6b2f6..1d992dc74877 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -1443,12 +1443,13 @@ static const struct camss_subdev_resources vfe_res_7280[] = {
>  		.regulators = {},
>  
>  		.clock = { "camnoc_axi", "cpas_ahb", "icp_ahb", "vfe0",
> -			   "vfe0_axi", "gcc_cam_hf_axi" },
> +			   "vfe0_axi", "gcc_axi_hf", "gcc_axi_sf" },


I don't get how this works with old DTS.

This looks like pure ABI break without any explanation.

Best regards,
Krzysztof