linux-kernel - Re: [PATCH 1/8] dmaengine: fsl-edma: select of_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e52a6aab-7981-4564-b057-fcaad396f45e@oss.nxp.com>
Date: Tue, 17 Dec 2024 16:28:48 +0200
From: Larisa Ileana Grigore <larisa.grigore@....nxp.com>
To: Frank Li <Frank.li@....com>
Cc: dmaengine@...r.kernel.org, imx@...ts.linux.dev,
 linux-kernel@...r.kernel.org, s32@....com,
 Christophe Lizzi <clizzi@...hat.com>, Alberto Ruiz <aruizrui@...hat.com>,
 Enric Balletbo <eballetb@...hat.com>
Subject: Re: [PATCH 1/8] dmaengine: fsl-edma: select of_dma_xlate based on the
 dmamuxs presence

On 12/16/2024 6:16 PM, Frank Li wrote:
> On Mon, Dec 16, 2024 at 09:58:11AM +0200, Larisa Grigore wrote:
>> Select the of_dma_xlate function based on the dmamuxs definition rather
>> than the FSL_EDMA_DRV_SPLIT_REG flag, which pertains to the eDMA3
>> layout.
> 
> Nit: Add space line here. Need empty line between paragraphs
> 
> Reviewed-by: Frank Li <Frank.Li@....com>
> 
Thank you Frank! Will be fixed in V2.

>> This change is a prerequisite for the S32G platforms, which integrate both
>> eDMAv3 and DMAMUX.
> 
> Nit: the same here.
> 
>> Existing platforms with FSL_EDMA_DRV_SPLIT_REG will not be impacted, as
>> they all have dmamuxs set to zero.
>>
>> Signed-off-by: Larisa Grigore <larisa.grigore@....nxp.com>
>> ---
>>   dcrivers/dma/fsl-edma-main.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/fsl-edma-main.c b/drivers/dma/fsl-edma-main.c
>> index 60de1003193a..2a7d19f51287 100644
>> --- a/drivers/dma/fsl-edma-main.c
>> +++ b/drivers/dma/fsl-edma-main.c
>> @@ -646,7 +646,7 @@ static int fsl_edma_probe(struct platform_device *pdev)
>>   	}
>>
>>   	ret = of_dma_controller_register(np,
>> -			drvdata->flags & FSL_EDMA_DRV_SPLIT_REG ? fsl_edma3_xlate : fsl_edma_xlate,
>> +a			drvdata->dmamuxs ? fsl_edma_xlate : fsl_edma3_xlate,
>>   			fsl_edma);
>>   	if (ret) {
>>   		dev_err(&pdev->dev,
>> --
>> 2.47.0
>>

Best regards,
Larisa