linux-kernel - Re: [PATCH] wifi: cw1200: Fix potential NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdY9RvHKSLcgbncaOoPjzQr4oziwpum-r5QjQxQeTT-JNg@mail.gmail.com>
Date: Tue, 17 Dec 2024 15:49:41 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Kalle Valo <kvalo@...nel.org>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org, 
	kernel test robot <lkp@...el.com>, Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH] wifi: cw1200: Fix potential NULL dereference

On Tue, Dec 17, 2024 at 3:31 PM Kalle Valo <kvalo@...nel.org> wrote:

> Linus Walleij <linus.walleij@...aro.org> writes:
>
> > A recent refactoring was identified by static analysis to
> > cause another potential NULL dereference, fix this!
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Closes: https://lore.kernel.org/r/202411271742.Xa7CNVh1-lkp@intel.com/
> > Fixes: 2719a9e7156c ("wifi: cw1200: Convert to GPIO descriptors")
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
>
> If it's ok for you, I'll add the smatch warning to the commit message:
>
> drivers/net/wireless/st/cw1200/cw1200_spi.c:440 cw1200_spi_disconnect() error: we previously assumed 'self' could be null (see line 433)

Sure go ahead!

Yours,
Linus Walleij