linux-kernel - Re: [PATCH] pwm: stm32: fix complementary output in round_waveform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dwwbefhhvjczcakd4nrrunzoq7mhzwrxxpm7gdtabgm6flk4cp@5w4usax4n67h>
Date: Tue, 17 Dec 2024 16:46:21 +0100
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
Cc: alexandre.torgue@...s.st.com, linux-pwm@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-stm32@...md-mailman.stormreply.com, olivier.moysan@...s.st.com
Subject: Re: [PATCH] pwm: stm32: fix complementary output in
 round_waveform_tohw

On Tue, Dec 17, 2024 at 04:00:21PM +0100, Fabrice Gasnier wrote:
> When the timer supports complementary output, the enable bit is
> overridden. It should be OR'ed. This makes all PWM channels for
> such timer not to work.
> 
> Fixes: deaba9cff809 ("pwm: stm32: Implementation of the waveform callbacks")
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...s.st.com>
> ---
>  drivers/pwm/pwm-stm32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
> index b889e64522c3..17e591f61efb 100644
> --- a/drivers/pwm/pwm-stm32.c
> +++ b/drivers/pwm/pwm-stm32.c
> @@ -84,7 +84,7 @@ static int stm32_pwm_round_waveform_tohw(struct pwm_chip *chip,
>  
>  	wfhw->ccer = TIM_CCER_CCxE(ch + 1);
>  	if (priv->have_complementary_output)
> -		wfhw->ccer = TIM_CCER_CCxNE(ch + 1);
> +		wfhw->ccer |= TIM_CCER_CCxNE(ch + 1);

Oh, indeed. Thanks for the fix.

Applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/fixes
and I will send it to Linus later this week.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)