| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CANn89iLL9EgqDz8sjMke9okhJpxtzZkcPvaEQ3s01F89H5RP3A@mail.gmail.com>
Date: Tue, 17 Dec 2024 18:06:50 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: syzbot <syzbot+38a095a81f30d82884c1@...kaller.appspotmail.com>
Cc: davem@...emloft.net, dsahern@...nel.org, horms@...nel.org, kuba@...nel.org,
linux-kernel@...r.kernel.org, martineau@...nel.org, matttbe@...nel.org,
netdev@...r.kernel.org, pabeni@...hat.com, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [net?] general protection fault in put_page (4)
On Tue, Dec 17, 2024 at 6:03 PM syzbot
<syzbot+38a095a81f30d82884c1@...kaller.appspotmail.com> wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 78d4f34e2115 Linux 6.13-rc3
> git tree: upstream
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=16445730580000
> kernel config: https://syzkaller.appspot.com/x/.config?x=6c532525a32eb57d
> dashboard link: https://syzkaller.appspot.com/bug?extid=38a095a81f30d82884c1
> compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=169b0b44580000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=13f502df980000
>
> Downloadable assets:
> disk image: https://storage.googleapis.com/syzbot-assets/7129ee07f8aa/disk-78d4f34e.raw.xz
> vmlinux: https://storage.googleapis.com/syzbot-assets/c23c0af59a16/vmlinux-78d4f34e.xz
> kernel image: https://storage.googleapis.com/syzbot-assets/031aecf04ea7/bzImage-78d4f34e.xz
>
> The issue was bisected to:
>
> commit b83fbca1b4c9c45628aa55d582c14825b0e71c2b
> Author: Matthieu Baerts (NGI0) <matttbe@...nel.org>
> Date: Mon Sep 2 10:45:53 2024 +0000
>
> mptcp: pm: reduce entries iterations on connect
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=163682df980000
> final oops: https://syzkaller.appspot.com/x/report.txt?x=153682df980000
> console output: https://syzkaller.appspot.com/x/log.txt?x=113682df980000
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+38a095a81f30d82884c1@...kaller.appspotmail.com
> Fixes: b83fbca1b4c9 ("mptcp: pm: reduce entries iterations on connect")
>
> Oops: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN PTI
> KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
> CPU: 1 UID: 0 PID: 5836 Comm: sshd Not tainted 6.13.0-rc3-syzkaller #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024
> RIP: 0010:_compound_head include/linux/page-flags.h:242 [inline]
> RIP: 0010:put_page+0x23/0x260 include/linux/mm.h:1552
> Code: 90 90 90 90 90 90 90 55 41 57 41 56 53 49 89 fe 48 bd 00 00 00 00 00 fc ff df e8 f8 5e 12 f8 49 8d 5e 08 48 89 d8 48 c1 e8 03 <80> 3c 28 00 74 08 48 89 df e8 8f c7 78 f8 48 8b 1b 48 89 de 48 83
> RSP: 0000:ffffc90003916c90 EFLAGS: 00010202
> RAX: 0000000000000001 RBX: 0000000000000008 RCX: ffff888030458000
> RDX: 0000000000000100 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: dffffc0000000000 R08: ffffffff898ca81d R09: 1ffff110054414ac
> R10: dffffc0000000000 R11: ffffed10054414ad R12: 0000000000000007
> R13: ffff88802a20a542 R14: 0000000000000000 R15: 0000000000000000
> FS: 00007f34f496e800(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f9d6ec9ec28 CR3: 000000004d260000 CR4: 00000000003526f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> Call Trace:
> <TASK>
> skb_page_unref include/linux/skbuff_ref.h:43 [inline]
> __skb_frag_unref include/linux/skbuff_ref.h:56 [inline]
> skb_release_data+0x483/0x8a0 net/core/skbuff.c:1119
> skb_release_all net/core/skbuff.c:1190 [inline]
> __kfree_skb+0x55/0x70 net/core/skbuff.c:1204
> tcp_clean_rtx_queue net/ipv4/tcp_input.c:3436 [inline]
> tcp_ack+0x2442/0x6bc0 net/ipv4/tcp_input.c:4032
> tcp_rcv_state_process+0x8eb/0x44e0 net/ipv4/tcp_input.c:6805
> tcp_v4_do_rcv+0x77d/0xc70 net/ipv4/tcp_ipv4.c:1939
> tcp_v4_rcv+0x2dc0/0x37f0 net/ipv4/tcp_ipv4.c:2351
> ip_protocol_deliver_rcu+0x22e/0x440 net/ipv4/ip_input.c:205
> ip_local_deliver_finish+0x341/0x5f0 net/ipv4/ip_input.c:233
> NF_HOOK+0x3a4/0x450 include/linux/netfilter.h:314
> NF_HOOK+0x3a4/0x450 include/linux/netfilter.h:314
> __netif_receive_skb_one_core net/core/dev.c:5672 [inline]
> __netif_receive_skb+0x2bf/0x650 net/core/dev.c:5785
> process_backlog+0x662/0x15b0 net/core/dev.c:6117
> __napi_poll+0xcb/0x490 net/core/dev.c:6883
> napi_poll net/core/dev.c:6952 [inline]
> net_rx_action+0x89b/0x1240 net/core/dev.c:7074
> handle_softirqs+0x2d4/0x9b0 kernel/softirq.c:561
> __do_softirq kernel/softirq.c:595 [inline]
> invoke_softirq kernel/softirq.c:435 [inline]
> __irq_exit_rcu+0xf7/0x220 kernel/softirq.c:662
> irq_exit_rcu+0x9/0x30 kernel/softirq.c:678
> instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1049 [inline]
> sysvec_apic_timer_interrupt+0x57/0xc0 arch/x86/kernel/apic/apic.c:1049
> asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:702
> RIP: 0033:0x7f34f4519ad5
> Code: 85 d2 74 0d 0f 10 02 48 8d 54 24 20 0f 11 44 24 20 64 8b 04 25 18 00 00 00 85 c0 75 27 41 b8 08 00 00 00 b8 0f 01 00 00 0f 05 <48> 3d 00 f0 ff ff 76 75 48 8b 15 24 73 0d 00 f7 d8 64 89 02 48 83
> RSP: 002b:00007ffec5b32ce0 EFLAGS: 00000246
> RAX: 0000000000000001 RBX: 00000000000668a0 RCX: 00007f34f4519ad5
> RDX: 00007ffec5b32d00 RSI: 0000000000000004 RDI: 0000564f4bc6cae0
> RBP: 0000564f4bc6b5a0 R08: 0000000000000008 R09: 0000000000000000
> R10: 00007ffec5b32de8 R11: 0000000000000246 R12: 0000564f48ea8aa4
> R13: 0000000000000001 R14: 0000564f48ea93e8 R15: 00007ffec5b32d68
> </TASK>
> Modules linked in:
> ---[ end trace 0000000000000000 ]---
> RIP: 0010:_compound_head include/linux/page-flags.h:242 [inline]
> RIP: 0010:put_page+0x23/0x260 include/linux/mm.h:1552
> Code: 90 90 90 90 90 90 90 55 41 57 41 56 53 49 89 fe 48 bd 00 00 00 00 00 fc ff df e8 f8 5e 12 f8 49 8d 5e 08 48 89 d8 48 c1 e8 03 <80> 3c 28 00 74 08 48 89 df e8 8f c7 78 f8 48 8b 1b 48 89 de 48 83
> RSP: 0000:ffffc90003916c90 EFLAGS: 00010202
> RAX: 0000000000000001 RBX: 0000000000000008 RCX: ffff888030458000
> RDX: 0000000000000100 RSI: 0000000000000000 RDI: 0000000000000000
> RBP: dffffc0000000000 R08: ffffffff898ca81d R09: 1ffff110054414ac
> R10: dffffc0000000000 R11: ffffed10054414ad R12: 0000000000000007
> R13: ffff88802a20a542 R14: 0000000000000000 R15: 0000000000000000
> FS: 00007f34f496e800(0000) GS:ffff8880b8700000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 00007f9d6ec9ec28 CR3: 000000004d260000 CR4: 00000000003526f0
> DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> ----------------
> Code disassembly (best guess):
> 0: 90 nop
> 1: 90 nop
> 2: 90 nop
> 3: 90 nop
> 4: 90 nop
> 5: 90 nop
> 6: 90 nop
> 7: 55 push %rbp
> 8: 41 57 push %r15
> a: 41 56 push %r14
> c: 53 push %rbx
> d: 49 89 fe mov %rdi,%r14
> 10: 48 bd 00 00 00 00 00 movabs $0xdffffc0000000000,%rbp
> 17: fc ff df
> 1a: e8 f8 5e 12 f8 call 0xf8125f17
> 1f: 49 8d 5e 08 lea 0x8(%r14),%rbx
> 23: 48 89 d8 mov %rbx,%rax
> 26: 48 c1 e8 03 shr $0x3,%rax
> * 2a: 80 3c 28 00 cmpb $0x0,(%rax,%rbp,1) <-- trapping instruction
> 2e: 74 08 je 0x38
> 30: 48 89 df mov %rbx,%rdi
> 33: e8 8f c7 78 f8 call 0xf878c7c7
> 38: 48 8b 1b mov (%rbx),%rbx
> 3b: 48 89 de mov %rbx,%rsi
> 3e: 48 rex.W
> 3f: 83 .byte 0x83
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkaller@...glegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> If the report is already addressed, let syzbot know by replying with:
> #syz fix: exact-commit-title
>
> If you want syzbot to run the reproducer, reply with:
> #syz test: git://repo/address.git branch-or-commit-hash
> If you attach or paste a git patch, syzbot will apply it before testing.
>
> If you want to overwrite report's subsystems, reply with:
> #syz set subsystems: new-subsystem
> (See the list of subsystem names on the web dashboard)
>
> If the report is a duplicate of another one, reply with:
> #syz dup: exact-subject-of-another-report
>
> If you want to undo deduplication, reply with:
> #syz undup
I spent some time on this bug before releasing it, because I have
other syzbot reports probably
caused by the same issue, hinting at shinfo->nr_frags corruption.
I will hold these reports to avoid flooding the mailing list.
Powered by blists - more mailing lists