linux-kernel - Re: [PATCH] clk: davinci: remove platform data struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Me7VAOc=p9skjVFb+m82HVEouL_zMpwKg1k-mMqLO7G2A@mail.gmail.com>
Date: Tue, 17 Dec 2024 18:31:17 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: David Lechner <david@...hnology.com>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] clk: davinci: remove platform data struct

On Mon, Dec 16, 2024 at 9:29 PM David Lechner <david@...hnology.com> wrote:
>
> On 12/10/24 11:57 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > There are no board files using struct davinci_pll_platform_data anymore.
> > The structure itself is currently used to store a single pointer. Let's
> > remove the struct definition, the header and rework the driver to not
> > require the syscon regmap to be stored in probe().
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> >
> > -     pdata = davinci_pll_get_pdata(dev);
> > -     if (!pdata) {
> > -             dev_err(dev, "missing platform data\n");
> > -             return -EINVAL;
> > -     }
> > +     if (dev->of_node)
>
> Or just leave out the if here.
>

Right, that's not at all necessary.

Bart