linux-kernel - Re: [PATCH v4] dt-bindings: mfd: sprd,sc2731: reference sprd,sc2731-efuse bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217-envoy-plant-c088f5f80bd1@spud>
Date: Tue, 17 Dec 2024 18:21:52 +0000
From: Conor Dooley <conor@...nel.org>
To: Stanislav Jakubek <stano.jakubek@...il.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Orson Zhai <orsonzhai@...il.com>,
	Baolin Wang <baolin.wang@...ux.alibaba.com>,
	Chunyan Zhang <zhang.lyra@...il.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] dt-bindings: mfd: sprd,sc2731: reference
 sprd,sc2731-efuse bindings

On Tue, Dec 17, 2024 at 08:43:30AM +0100, Stanislav Jakubek wrote:
> On Mon, Dec 16, 2024 at 06:39:09PM +0000, Conor Dooley wrote:
> > On Mon, Dec 16, 2024 at 11:13:24AM +0100, Stanislav Jakubek wrote:
> > > Directly reference the sc2731-efuse bindings to simplify the schema.
> > > Remove the duplicate example from the efuse bindings.
> > > While at it, add the "pmic_adc" label that was missed during the
> > > initial YAML conversion.
> > > 
> > > Signed-off-by: Stanislav Jakubek <stano.jakubek@...il.com>
> > > ---
> > > Changes in V4:
> > > - rebase on next-20241216
> > > - drop patch 1 (already applied)
> > > - add the pmic_adc label that was initially missed
> > > 
> > > Changes in V3:
> > > - new patch due to a missing dependency in the MFD tree 
> > > 
> > > Link to V3: https://lore.kernel.org/lkml/cd8cc95b59c31418b174bba521dd2599a7929fda.1730709384.git.stano.jakubek@gmail.com/
> > > Link to V2: https://lore.kernel.org/lkml/ZyExK01iprBHhGm6@standask-GA-A55M-S2HP/
> > > Link to V1: https://lore.kernel.org/lkml/Zr3X1RoQs7ElTnlJ@standask-GA-A55M-S2HP/
> > > 
> > >  .../devicetree/bindings/mfd/sprd,sc2731.yaml  | 12 ++------
> > >  .../bindings/nvmem/sprd,sc2731-efuse.yaml     | 29 -------------------
> > >  2 files changed, 2 insertions(+), 39 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> > > index 8beec7e8e4c6..b023e1ef8d3c 100644
> > > --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> > > +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> > > @@ -67,15 +67,7 @@ patternProperties:
> > >  
> > >    "^efuse@[0-9a-f]+$":
> > >      type: object
> > > -    additionalProperties: true
> > > -    properties:
> > > -      compatible:
> > > -        enum:
> > > -          - sprd,sc2720-efuse
> > > -          - sprd,sc2721-efuse
> > > -          - sprd,sc2723-efuse
> > > -          - sprd,sc2730-efuse
> > > -          - sprd,sc2731-efuse
> > > +    $ref: /schemas/nvmem/sprd,sc2731-efuse.yaml#
> > >  
> > >    "^fuel-gauge@[0-9a-f]+$":
> > >      type: object
> > > @@ -199,7 +191,7 @@ examples:
> > >            };
> > >          };
> > >  
> > > -        adc@480 {
> > > +        pmic_adc: adc@480 {
> > 
> > I don't understand the point of this hunk, nothing ever references it.
> > Examples aren't supposed to contain unused labels.
> 
> Hi Conor,
> 
> this label is used by the fuel-gauge io-channels in the example:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml?h=v6.13-rc3#n219

Ah shit, my bad. I didn't realise all that was one example.
Acked-by: Conor Dooley <conor.dooley@...rochip.com>

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)