linux-kernel - Re: [PATCH 1/3] ring-buffer: Add uname to match criteria for persistent ring buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217141417.23b875f1@gandalf.local.home>
Date: Tue, 17 Dec 2024 14:14:17 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org, Masami
 Hiramatsu <mhiramat@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, stable@...r.kernel.org
Subject: Re: [PATCH 1/3] ring-buffer: Add uname to match criteria for
 persistent ring buffer

On Tue, 17 Dec 2024 14:07:50 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:

> On Tue, 17 Dec 2024 11:03:28 -0800
> Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> > On Tue, 17 Dec 2024 at 10:42, Linus Torvalds
> > <torvalds@...ux-foundation.org> wrote:  
> > >
> > > My initial suggestion was to just fix up the boot time array.
> > >
> > > I think that's actually wrong. Just print the raw data and analyze it
> > > in user space.    
> > 
> > .. I still think it's not the optimal solution, but fixing up the
> > event data from the previous boot (*before* printing it, and entirely
> > independently of vsnprintf()) would at least avoid the whole "mess
> > with vsnprintf and switch the format string around as you are trying
> > to walk the va_list in sync".

And that code that does the va_list and vsnprintf() tricks is going to be
removed as soon as that patch set finishes going through my full test suite,
and you are OK with the solution.

Again, that patch set is here:

  https://lore.kernel.org/linux-trace-kernel/20241217024118.587584221@goodmis.org/

-- Steve