linux-kernel - Re: [PATCH AUTOSEL 5.15 13/13] ALSA: usb: Fix UBSAN warning in parse_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2HN39E2yUoqtCGh@lappy>
Date: Tue, 17 Dec 2024 14:15:43 -0500
From: Sasha Levin <sashal@...nel.org>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	syzbot+78d5b129a762182225aa@...kaller.appspotmail.com,
	perex@...ex.cz, tiwai@...e.com, kl@...wtf,
	peter.ujfalusi@...ux.intel.com, xristos.thes@...il.com,
	linux-sound@...r.kernel.org,
	Vegard Nossum <vegard.nossum@...cle.com>
Subject: Re: [PATCH AUTOSEL 5.15 13/13] ALSA: usb: Fix UBSAN warning in
 parse_audio_unit()

On Tue, Dec 17, 2024 at 11:54:49AM +0530, Harshit Mogalapalli wrote:
>Hi Sasha,
>
>On 28/07/24 21:38, Sasha Levin wrote:
>>From: Takashi Iwai <tiwai@...e.de>
>>
>>[ Upstream commit 2f38cf730caedaeacdefb7ff35b0a3c1168117f9 ]
>>
>>A malformed USB descriptor may pass the lengthy mixer description with
>>a lot of channels, and this may overflow the 32bit integer shift
>>size, as caught by syzbot UBSAN test.  Although this won't cause any
>>real trouble, it's better to address.
>>
>>This patch introduces a sanity check of the number of channels to bail
>>out the parsing when too many channels are found.
>>
>>Reported-by: syzbot+78d5b129a762182225aa@...kaller.appspotmail.com
>>Closes: https://lore.kernel.org/0000000000000adac5061d3c7355@google.com
>>Link: https://patch.msgid.link/20240715123619.26612-1-tiwai@suse.de
>>Signed-off-by: Takashi Iwai <tiwai@...e.de>
>>Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>FYI: This 13 patch series and similar AUTOSEL sets for other stable 
>kernels didn't go into stable yet.

Huh, thanks for that.

I've tried to look at the history, and I'm quite confused about what's
happening. My scripts must have gone rogue at some point.

-- 
Thanks,
Sasha