linux-kernel - Re: [PATCH] drm/xe/vsec: enforce CONFIG_INTEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <640211a8-9516-4574-99a6-e61354d613ff@app.fastmail.com>
Date: Tue, 17 Dec 2024 21:39:13 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Lucas De Marchi" <lucas.demarchi@...el.com>
Cc: "Rodrigo Vivi" <rodrigo.vivi@...el.com>,
 "Arnd Bergmann" <arnd@...nel.org>, michael.j.ruhl@...el.com,
 Thomas Hellström <thomas.hellstrom@...ux.intel.com>,
 "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
 "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "Dave Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>,
 "David E. Box" <david.e.box@...ux.intel.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 "Andy Shevchenko" <andriy.shevchenko@...ux.intel.com>,
 "Jani Nikula" <jani.nikula@...el.com>,
 "Geert Uytterhoeven" <geert+renesas@...der.be>,
 "Tejas Upadhyay" <tejas.upadhyay@...el.com>,
 "Hans de Goede" <hdegoede@...hat.com>, intel-xe@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/xe/vsec: enforce CONFIG_INTEL_VSEC dependency

On Tue, Dec 17, 2024, at 21:14, Lucas De Marchi wrote:
> On Tue, Dec 17, 2024 at 08:28:59PM +0100, Arnd Bergmann wrote:
>>On Tue, Dec 17, 2024, at 19:52, Rodrigo Vivi wrote:
>>> On Tue, Dec 17, 2024 at 08:18:44AM +0100, Arnd Bergmann wrote:
>>>> From: Arnd Bergmann <arnd@...db.de>
>>>>
>>>> When INTEL_VSEC is in a loadable module, XE cannot be built-in any more:
>>>>
>>>> x86_64-linux-ld: vmlinux.o: in function `xe_vsec_init':
>>>> (.text+0x19861bf): undefined reference to `intel_vsec_register'
>>>>
>>>> This could be enforced using a 'depends on INTEL_VSEC || !INTEL_VSEC'
>>>> style dependency to allow building with VSEC completely disabled.
>>>> My impression here is that this was not actually intended, and that
>>>> continuing to support that combination would lead to more build bugs.
>
> why? if xe is built-in, vsec needs to be built-in as well. If xe is a
> module, vsec can be either built-in or a module.

"depends on INTEL_VSEC" enforces that hard dependency. The difference
with "depends on INTEL_VSEC || !INTEL_VSEC" is that it also allows
XE to be either built-in or a module if INTEL_VSEC is turned off,
as it would be the case on non-x86.

       Arnd