linux-kernel - Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for virtio-blk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <92eafd0f-943a-4595-8df3-45128cac5ee9@kernel.dk>
Date: Tue, 17 Dec 2024 14:07:26 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Stefan Hajnoczi <stefanha@...il.com>
Cc: Jingbo Xu <jefflexu@...ux.alibaba.com>,
 Christoph Hellwig <hch@...radead.org>,
 Ferry Meng <mengferry@...ux.alibaba.com>,
 "Michael S . Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 linux-block@...r.kernel.org, virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org, io-uring@...r.kernel.org,
 Joseph Qi <joseph.qi@...ux.alibaba.com>
Subject: Re: [PATCH 0/3][RFC] virtio-blk: add io_uring passthrough support for
 virtio-blk

On 12/17/24 2:00 PM, Stefan Hajnoczi wrote:
> On Tue, 17 Dec 2024 at 12:54, Jens Axboe <axboe@...nel.dk> wrote:
>>
>> On 12/16/24 11:08 PM, Jingbo Xu wrote:
>>>> That's why I asked Jens to weigh in on whether there is a generic
>>>> block layer solution here. If uring_cmd is faster then maybe a generic
>>>> uring_cmd I/O interface can be defined without tying applications to
>>>> device-specific commands. Or maybe the traditional io_uring code path
>>>> can be optimized so that bypass is no longer attractive.
>>
>> It's not that the traditional io_uring code path is slower, it's in fact
>> basically the same thing. It's that all the other jazz that happens
>> below io_uring slows things down, which is why passthrough ends up being
>> faster.
> 
> Are you happy with virtio_blk passthrough or do you want a different approach?

I think it looks fine.

-- 
Jens Axboe