linux-kernel - Re: [PATCH v1 2/4] regulator: tps65219: Update driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2fdf8fd0-b764-4720-8f7b-71b5d63d2541@ti.com>
Date: Tue, 17 Dec 2024 15:16:44 -0600
From: Andrew Davis <afd@...com>
To: Mark Brown <broonie@...nel.org>, Shree Ramamoorthy <s-ramamoorthy@...com>
CC: <aaro.koskinen@....fi>, <andreas@...nade.info>, <khilman@...libre.com>,
        <rogerq@...nel.org>, <tony@...mide.com>, <lgirdwood@...il.com>,
        <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <m-leonard@...com>, <praneeth@...com>
Subject: Re: [PATCH v1 2/4] regulator: tps65219: Update driver name

On 12/17/24 3:01 PM, Mark Brown wrote:
> On Tue, Dec 17, 2024 at 02:45:24PM -0600, Shree Ramamoorthy wrote:
> 
>> Follow the same naming convention in tps6594-regulator.c with
>> tpsxxx-regulator instead of tpsxxx-pmic.
> 
>>   static struct platform_driver tps65219_regulator_driver = {
>>   	.driver = {
>> -		.name = "tps65219-pmic",
>> +		.name = "tps65219-regulator",
>>   		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> 
> This isn't just a naming convention thing AFACIT, the MFD registers the
> new name so the driver wouldn't previously have loaded.  How did this
> ever work?

It matches based on the platform device .id_table[0] which does have
"tps65219-regulator" listed, the driver .name itself is only used
as a last fallback when there is no .id_table.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/platform.c#n1352

Andrew