linux-kernel - Re: [PATCH 2/2] dt-bindings: media: imx219: Describe sensor address using the reg property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bf619a0e-f470-4bdb-8d09-2cea172bfe8e@ixit.cz>
Date: Tue, 17 Dec 2024 16:22:29 -0500
From: David Heidelberg <david@...t.cz>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: media: imx219: Describe sensor address
 using the reg property

Oh, the checkpatch script keeps warning me every time I commit—I guess 
it needs to be addressed.

I currently use:

[diff]
   srcprefix = ./
   dstprefix = ./

Originally, my intention was to use:

[diff]
   noprefix = true

This was to make it easier to copy-paste directly into the shell (git 
log -p, etc.). However, it ended up breaking too many applications. 
Setting srcprefix and dstprefix instead keeps everything working properly.

Is there any chance a patch allowing a ./ prefix could make it into 
checkpatch? What do you think, Krzysztof?

Thank you,
David

On 17/12/2024 02:40, Krzysztof Kozlowski wrote:
> On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote:
>> Use the reg property instead of text in the description.
>> Drop useless description of reg property.
>>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml
> 
> You are using non-standard tools to generate patches. See checkpatch
> warnings.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Best regards,
> Krzysztof
> 

-- 
David Heidelberg