linux-kernel - Re: [PATCH] net: core: Convert inet_addr_is_any() to sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217035657.GA14719@lst.de>
Date: Tue, 17 Dec 2024 04:56:58 +0100
From: Christoph Hellwig <hch@....de>
To: Kees Cook <kees@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
	Chaitanya Kulkarni <kch@...dia.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Mike Christie <michael.christie@...cle.com>,
	Max Gurtovoy <mgurtovoy@...dia.com>,
	Maurizio Lombardi <mlombard@...hat.com>,
	Dmitry Bogdanov <d.bogdanov@...ro.com>,
	Mingzhe Zou <mingzhe.zou@...ystack.cn>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Simon Horman <horms@...nel.org>,
	"Dr. David Alan Gilbert" <linux@...blig.org>,
	linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
	target-devel@...r.kernel.org, netdev@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] net: core: Convert inet_addr_is_any() to
 sockaddr_storage

On Mon, Dec 16, 2024 at 05:26:19PM -0800, Kees Cook wrote:
> -extern bool inet_addr_is_any(struct sockaddr *addr);
> +extern bool inet_addr_is_any(struct sockaddr_storage *addr);

You might want to drop the pointless extern here.

Otherwise this looks great:

Reviewed-by: Christoph Hellwig <hch@....de>