linux-kernel - Re: [RFC PATCH 03/12] khugepaged: Generalize hugepage_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2D8Qr44vqWpH_Om@casper.infradead.org>
Date: Tue, 17 Dec 2024 04:21:22 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Dev Jain <dev.jain@....com>
Cc: akpm@...ux-foundation.org, david@...hat.com,
	kirill.shutemov@...ux.intel.com, ryan.roberts@....com,
	anshuman.khandual@....com, catalin.marinas@....com, cl@...two.org,
	vbabka@...e.cz, mhocko@...e.com, apopple@...dia.com,
	dave.hansen@...ux.intel.com, will@...nel.org, baohua@...nel.org,
	jack@...e.cz, srivatsa@...il.mit.edu, haowenchao22@...il.com,
	hughd@...gle.com, aneesh.kumar@...nel.org,
	yang@...amperecomputing.com, peterx@...hat.com, ioworker0@...il.com,
	wangkefeng.wang@...wei.com, ziy@...dia.com, jglisse@...gle.com,
	surenb@...gle.com, vishal.moola@...il.com, zokeefe@...gle.com,
	zhengqi.arch@...edance.com, jhubbard@...dia.com, 21cnbao@...il.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 03/12] khugepaged: Generalize
 hugepage_vma_revalidate()

On Mon, Dec 16, 2024 at 10:20:56PM +0530, Dev Jain wrote:
>  static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address,
>  				   bool expect_anon,
> -				   struct vm_area_struct **vmap,
> +				   struct vm_area_struct **vmap, int order,

orders are unsigned.  i'm going to stop leaving this feedback here, but
please fix the entire series for this braino.