linux-kernel - Re: [PATCH 1/3] include/linux.h: use linux/magic.h to get XFS_SUPER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2EOpTVkTvetGRvh@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Date: Tue, 17 Dec 2024 11:09:49 +0530
From: Ojaswin Mujoo <ojaswin@...ux.ibm.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: linux-ext4@...r.kernel.org, linux-xfs@...r.kernel.org,
        Ritesh Harjani <ritesh.list@...il.com>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org,
        Andrey Albershteyn <aalbersh@...nel.org>,
        "Darrick J . Wong" <djwong@...nel.org>,
        John Garry <john.g.garry@...cle.com>
Subject: Re: [PATCH 1/3] include/linux.h: use linux/magic.h to get
 XFS_SUPER_MAGIC

On Mon, Dec 16, 2024 at 12:28:00AM -0800, Christoph Hellwig wrote:
> On Sun, Dec 15, 2024 at 02:47:15PM +0530, Ojaswin Mujoo wrote:
> > -	return (statfsbuf.f_type == 0x58465342);	/* XFSB */
> > +	return (statfsbuf.f_type == XFS_SUPER_MAGIC);
> 
> Might be worth dropping the superfluous braces here while you're at it.

Thanks for the review Christoph, I will fix the braces here.

regards,
ojaswin
> 
> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
>