linux-kernel - Re: [PATCH] virtio: fix reference leak in register_virtio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1734414558.011073-1-xuanzhuo@linux.alibaba.com>
Date: Tue, 17 Dec 2024 13:49:18 +0800
From: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
To: Ma Ke <make_ruc2021@....com>
Cc: virtualization@...ts.linux.dev,
 linux-kernel@...r.kernel.org,
 Ma Ke <make_ruc2021@....com>,
 stable@...r.kernel.org,
 mst@...hat.com,
 jasowang@...hat.com,
 eperezma@...hat.com,
 arnd@...db.de,
 viresh.kumar@...aro.org
Subject: Re: [PATCH] virtio: fix reference leak in register_virtio_device()

On Tue, 17 Dec 2024 11:54:32 +0800, Ma Ke <make_ruc2021@....com> wrote:
> When device_add(&dev->dev) failed, calling put_device() to explicitly
> release dev->dev. Otherwise, it could cause double free problem.

Who frees it doublely?
If device_add() failed, the put_device is called inside device_add(),
why we need to call it again?

Maybe you need to say more?

Thanks.


>
> Found by code review.
>
> Cc: stable@...r.kernel.org
> Fixes: 694a1116b405 ("virtio: Bind virtio device to device-tree node")
> Signed-off-by: Ma Ke <make_ruc2021@....com>
> ---
>  drivers/virtio/virtio.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c
> index b9095751e43b..ac721b5597e8 100644
> --- a/drivers/virtio/virtio.c
> +++ b/drivers/virtio/virtio.c
> @@ -503,6 +503,7 @@ int register_virtio_device(struct virtio_device *dev)
>
>  out_of_node_put:
>  	of_node_put(dev->dev.of_node);
> +	put_device(&dev->dev);
>  out_ida_remove:
>  	ida_free(&virtio_index_ida, dev->index);
>  out:
> --
> 2.25.1
>