linux-kernel - Re: [PATCH v6 0/5] Fix USB suspend on TI J7200 (cdns3-ti, cdns3, xhci)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217061734.GB13482@nchen-desktop>
Date: Tue, 17 Dec 2024 14:17:34 +0800
From: Peter Chen <peter.chen@...nel.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Pawel Laszczak <pawell@...ence.com>, Roger Quadros <rogerq@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...el.com>,
	Grégory Clement <gregory.clement@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/5] Fix USB suspend on TI J7200 (cdns3-ti, cdns3,
 xhci)

On 24-12-16 15:09:00, Théo Lebrun wrote:
> Hello Peter,
> 
> On Sat Dec 14, 2024 at 10:06 AM CET, Peter Chen wrote:
> > On 24-12-10 18:13:34, Théo Lebrun wrote:
> > > Currently, system-wide suspend is broken on J7200 because of a
> > > controller reset. The TI wrapper does not get re-initialised at resume
> > > and the first register access from cdns core fails.
> > > 
> > > We address that in two ways:
> > > 
> > >  - In the cdns3-ti wrapper, if a reset has occured at resume,
> > >    we reconfigure the hardware.
> > > 
> > >  - We add a xhci->lost_power flag. Identical to the XHCI_RESET_ON_RESUME
> > >    quirk, expect that it can be set at runtime.
> > > 
> > >    At resume, to summarise, we do:
> > >       xhci->lost_power = cdns_power_is_lost(cdns);
> >
> > Is it possible you go to change xhci quirks runtime?
> 
> I always assumed quirks were read-only once probe was finished.
> If I was wrong then we can remove xhci->lost_power and edit
> xhci->quirks instead.
> 

I just want to see if we could avoid change common code, would you
please confirm with xHCI maintainer Mathias Nyman?

Peter