linux-kernel - Re: [RESEND PATCH] nios2: Use str_yes_no() helper in show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4b6088e7-88ec-4181-9f4a-f8411a11a4e7@kernel.org>
Date: Mon, 16 Dec 2024 18:42:30 -0600
From: Dinh Nguyen <dinguyen@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] nios2: Use str_yes_no() helper in show_cpuinfo()

On 12/9/24 05:06, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@...ux.dev>
> ---
>   arch/nios2/kernel/cpuinfo.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/nios2/kernel/cpuinfo.c b/arch/nios2/kernel/cpuinfo.c
> index 338849c430a5..7b1e8f9128e9 100644
> --- a/arch/nios2/kernel/cpuinfo.c
> +++ b/arch/nios2/kernel/cpuinfo.c
> @@ -143,11 +143,11 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>   		   " DIV:\t\t%s\n"
>   		   " BMX:\t\t%s\n"
>   		   " CDX:\t\t%s\n",
> -		   cpuinfo.has_mul ? "yes" : "no",
> -		   cpuinfo.has_mulx ? "yes" : "no",
> -		   cpuinfo.has_div ? "yes" : "no",
> -		   cpuinfo.has_bmx ? "yes" : "no",
> -		   cpuinfo.has_cdx ? "yes" : "no");
> +		   str_yes_no(cpuinfo.has_mul),
> +		   str_yes_no(cpuinfo.has_mulx),
> +		   str_yes_no(cpuinfo.has_div),
> +		   str_yes_no(cpuinfo.has_bmx),
> +		   str_yes_no(cpuinfo.has_cdx));
>   
>   	seq_printf(m,
>   		   "Icache:\t\t%ukB, line length: %u\n",

Applied!

Thanks,
Dinh