linux-kernel - Re: [PATCH] btrfs: don't include '<linux/rwlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0199c644-dfd7-43ce-b02a-459461299fb7@gmx.com>
Date: Tue, 17 Dec 2024 17:44:03 +1030
From: Qu Wenruo <quwenruo.btrfs@....com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-kernel@...r.kernel.org
Cc: Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
 David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org
Subject: Re: [PATCH] btrfs: don't include '<linux/rwlock_types.h>' directly



在 2024/12/17 17:35, Wolfram Sang 写道:
> The header clearly states that it does not want to be included directly,
> only via '<linux/spinlock_types.h>'. Replace the include accordingly.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>   fs/btrfs/fs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/fs.h b/fs/btrfs/fs.h
> index 79a1a3d6f04d..78e558652908 100644
> --- a/fs/btrfs/fs.h
> +++ b/fs/btrfs/fs.h
> @@ -14,7 +14,7 @@
>   #include <linux/lockdep.h>
>   #include <linux/spinlock.h>
>   #include <linux/mutex.h>
> -#include <linux/rwlock_types.h>
> +#include <linux/spinlock_types.h>

I think we can just remove the *_type.h include header completely.

For non-RT build, spinlock.h will include linux/rwlock.h, and
spinlock_types.h unconditionally.

Thanks,
Qu
>   #include <linux/rwsem.h>
>   #include <linux/semaphore.h>
>   #include <linux/list.h>