linux-kernel - [PATCH] spi: fix reference leak in spi_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20241217073133.2908052-1-make_ruc2021@163.com>
Date: Tue, 17 Dec 2024 15:31:33 +0800
From: Ma Ke <make_ruc2021@....com>
To: broonie@...nel.org,
	aaro.koskinen@...ia.com
Cc: linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Ma Ke <make_ruc2021@....com>,
	stable@...r.kernel.org
Subject: [PATCH] spi: fix reference leak in spi_register_controller()

Once device_add() failed, we should call put_device() to decrement
reference count for cleanup. Or it could cause memory leak.

Found by code review.

Cc: stable@...r.kernel.org
Fixes: f9981d4f50b4 ("spi: spi_register_controller(): free bus id on error paths")
Signed-off-by: Ma Ke <make_ruc2021@....com>
---
 drivers/spi/spi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index ff1add2ecb91..6477c2f4ae82 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -3339,8 +3339,10 @@ int spi_register_controller(struct spi_controller *ctlr)
 		ctlr->last_cs[idx] = SPI_INVALID_CS;
 
 	status = device_add(&ctlr->dev);
-	if (status < 0)
+	if (status < 0) {
+		put_device(&ctlr->dev);
 		goto free_bus_id;
+	}
 	dev_dbg(dev, "registered %s %s\n",
 			spi_controller_is_target(ctlr) ? "target" : "host",
 			dev_name(&ctlr->dev));
@@ -3356,6 +3358,7 @@ int spi_register_controller(struct spi_controller *ctlr)
 		status = spi_controller_initialize_queue(ctlr);
 		if (status) {
 			device_del(&ctlr->dev);
+			put_device(&ctlr->dev);
 			goto free_bus_id;
 		}
 	}
-- 
2.25.1