linux-kernel - Re: kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z2Erda0/c62UwolB@rli9-mobl>
Date: Tue, 17 Dec 2024 15:42:45 +0800
From: Philip Li <philip.li@...el.com>
To: kernel test robot <lkp@...el.com>
CC: Masahiro Yamada <masahiroy@...nel.org>, <oe-kbuild-all@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Nathan Chancellor <nathan@...nel.org>
Subject: Re: kernel/reboot.c:226: warning: Function parameter or struct
 member 'cmd' not described in 'do_kernel_restart'

On Tue, Dec 17, 2024 at 01:02:37PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   f44d154d6e3d633d4c49a5d6aed8a0e4684ae25e
> commit: 92ef432f027cffe0ff91ff2cbe9258d89ca53968 kbuild: support W=c and W=e shorthands for Kconfig
> date:   1 year ago
> config: m68k-allnoconfig (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 12.4.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241217/202412171248.ro76Gqt1-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412171248.ro76Gqt1-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):

Sorry, kindly ignore this report that the commit is not the right one for the issue.

> 
> >> kernel/reboot.c:226: warning: Function parameter or struct member 'cmd' not described in 'do_kernel_restart'
> >> kernel/reboot.c:952: warning: Function parameter or struct member 'poweroff_delay_ms' not described in 'hw_failure_emergency_poweroff'
> --
>    lib/vsprintf.c: In function 'va_format':
> >> lib/vsprintf.c:1683:9: warning: function 'va_format' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>     1683 |         buf += vsnprintf(buf, end > buf ? end - buf : 0, va_fmt->fmt, va);
>          |         ^~~
> --
> >> lib/hweight.c:14: warning: Function parameter or struct member 'w' not described in '__sw_hweight32'
> >> lib/hweight.c:14: warning: expecting prototype for hweightN(). Prototype was for __sw_hweight32() instead
> --
>    drivers/clk/clkdev.c: In function 'vclkdev_alloc':
> >> drivers/clk/clkdev.c:173:17: warning: function 'vclkdev_alloc' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>      173 |                 vscnprintf(cla->dev_id, sizeof(cla->dev_id), dev_fmt, ap);
>          |                 ^~~~~~~~~~
> 
> 
> vim +226 kernel/reboot.c
> 
> b63adb979583ef Guenter Roeck 2014-09-26  213  
> b63adb979583ef Guenter Roeck 2014-09-26  214  /**
> b63adb979583ef Guenter Roeck 2014-09-26  215   *	do_kernel_restart - Execute kernel restart handler call chain
> b63adb979583ef Guenter Roeck 2014-09-26  216   *
> b63adb979583ef Guenter Roeck 2014-09-26  217   *	Calls functions registered with register_restart_handler.
> b63adb979583ef Guenter Roeck 2014-09-26  218   *
> b63adb979583ef Guenter Roeck 2014-09-26  219   *	Expected to be called from machine_restart as last step of the restart
> b63adb979583ef Guenter Roeck 2014-09-26  220   *	sequence.
> b63adb979583ef Guenter Roeck 2014-09-26  221   *
> b63adb979583ef Guenter Roeck 2014-09-26  222   *	Restarts the system immediately if a restart handler function has been
> b63adb979583ef Guenter Roeck 2014-09-26  223   *	registered. Otherwise does nothing.
> b63adb979583ef Guenter Roeck 2014-09-26  224   */
> b63adb979583ef Guenter Roeck 2014-09-26  225  void do_kernel_restart(char *cmd)
> b63adb979583ef Guenter Roeck 2014-09-26 @226  {
> b63adb979583ef Guenter Roeck 2014-09-26  227  	atomic_notifier_call_chain(&restart_handler_list, reboot_mode, cmd);
> b63adb979583ef Guenter Roeck 2014-09-26  228  }
> b63adb979583ef Guenter Roeck 2014-09-26  229  
> 
> :::::: The code at line 226 was first introduced by commit
> :::::: b63adb979583ef185718d774d8162387db5589c0 kernel: add support for kernel restart handler call chain
> 
> :::::: TO: Guenter Roeck <linux@...ck-us.net>
> :::::: CC: Guenter Roeck <linux@...ck-us.net>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>