linux-kernel - Re: [PATCH] RDMA/srp: Fix error handling in srp_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2024121717-trustful-opulently-c386@gregkh>
Date: Tue, 17 Dec 2024 09:04:34 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Ma Ke <make_ruc2021@....com>
Cc: bvanassche@....org, jgg@...pe.ca, leon@...nel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] RDMA/srp: Fix error handling in srp_add_port

On Tue, Dec 17, 2024 at 03:55:38PM +0800, Ma Ke wrote:
> The reference count of the device incremented in device_initialize() is
> not decremented when device_add() fails. Add a put_device() call before
> returning from the function to decrement reference count for cleanup.
> Or it could cause memory leak.

That is not what you did here.  Please be more careful when sending out
"bugfixes" like this.

thanks,

greg k-h