[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6e22585f8d374f8e26a2a51153680041ad8b1bea.camel@linaro.org>
Date: Tue, 17 Dec 2024 08:34:50 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Peter Griffin
<peter.griffin@...aro.org>, Tudor Ambarus <tudor.ambarus@...aro.org>, Alim
Akhtar <alim.akhtar@...sung.com>, Will McVicker <willmcvicker@...gle.com>,
kernel-team@...roid.com, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH 3/4] arm64: dts: exynos: gs101-oriole: move common
Pixel6 & 6Pro parts into a .dtsi
On Tue, 2024-12-17 at 08:38 +0100, Krzysztof Kozlowski wrote:
> On Mon, Dec 16, 2024 at 01:06:28PM +0000, André Draszik wrote:
> > In order to support Pixel 6 (Oriole) and Pixel 6 Pro (Raven) properly,
> > we have to be able to distinguish them properly as we add support for
> > more features.
> >
> > For example, Raven has a larger display. There are other differences,
> > like battery design capacity, etc.
> >
> > Move all the parts that are common for now into a gs101-raviole.dtsi,
> > and just leave the display related things in gs101-oriole.dts.
> >
> > Raviole was chosen as the name because Google uses that when referring
> > to the combination of Oriole & Raven, keeping the familiar terminology.
> >
> > Signed-off-by: André Draszik <andre.draszik@...aro.org>
> >
> > ---
> > Note: MAINTAINERS doesn't need updating, it covers this whole directory
> > ---
> > arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 290 +-------------------
> > .../boot/dts/exynos/google/gs101-raviole.dtsi | 297 +++++++++++++++++++++
> > 2 files changed, 305 insertions(+), 282 deletions(-)
> >
>
> This looks like move of the code, so -M/-B/-C format patch arguments
> would create better diff.
Ah, yes, forgot about those when I switched to using b4 instead of
custom scripts...
Cheers,
Andre
Powered by blists - more mailing lists