linux-kernel - Re: [PATCH v4] leds: pwm-multicolor: Disable PWM when going to suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bhymumlk7nesrcdovmp5shhelcqrs5i4eorqoerobtc5p6jifz@ychl36jc2h5q>
Date: Tue, 17 Dec 2024 09:55:22 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Jakob Riepler <jakob+lkml@...anoidlabs.org>
Cc: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] leds: pwm-multicolor: Disable PWM when going to
 suspend

On Mon, Dec 16, 2024 at 10:37:55PM +0100, Jakob Riepler wrote:
> This fixes suspend on platforms like stm32mp1xx, where the PWM consumer
> has to be disabled for the PWM to enter suspend.
> Another positive side effect is that active-low LEDs now properly
> turn off instead of going back to full brightness when they are set to 0.
> 
> Link: https://lore.kernel.org/all/20240417153846.271751-2-u.kleine-koenig@pengutronix.de/
> Signed-off-by: Jakob Riepler <jakob+lkml@...anoidlabs.org>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>

Now there are just nitpicks left:

 - Your S-o-b usually comes last.

 - The encoding of your mail is strange. It claims 8bit us-ascii which
   doesn't make sense. Depending on the mail reader and its locale my
   name might show as Uwe Kleine-K��nig. See also
   https://lore.kernel.org/all/20241216213754.18374-2-jakob+lkml@paranoidlabs.org/
   which says "Warning: decoded text below may be mangled, UTF-8
   assumed".

Many maintainers don't care about the first item and if Lee has a sane
environment my name makes it correctly into the git history. So from my
side that's no reason for a v5, but for future patches it would be great
to improve here.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)