linux-kernel - Re: imx8m-blk-ctrl: WARNING, no release() function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8956e0daffc89f8c6791f8a53b1666ca31011a45.camel@pengutronix.de>
Date: Tue, 17 Dec 2024 10:37:14 +0100
From: Lucas Stach <l.stach@...gutronix.de>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>, Peng Fan <peng.fan@....com>
Cc: Francesco Dolcini <francesco@...cini.it>, "linux-pm@...r.kernel.org"
 <linux-pm@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 Ulf Hansson <ulf.hansson@...aro.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team
 <kernel@...gutronix.de>,  Fabio Estevam <festevam@...il.com>, Marek Vasut
 <marex@...x.de>, "linux-arm-kernel@...ts.infradead.org"
 <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, Jindong Yue <jindong.yue@....com>, Benjamin
 Gaignard <benjamin.gaignard@...labora.com>, Paul Elder
 <paul.elder@...asonboard.com>,  Hervé Codina
 <herve.codina@...tlin.com>
Subject: Re: imx8m-blk-ctrl: WARNING, no release() function

Hi Luca,

Am Dienstag, dem 17.12.2024 um 09:42 +0100 schrieb Luca Ceresoli:
> Hello Peng,
> 
> On Tue, 17 Dec 2024 01:39:09 +0000
> Peng Fan <peng.fan@....com> wrote:
> 
> > > Subject: imx8m-blk-ctrl: WARNING, no release() function  
> > 
> > Please try this patch.
> > https://lore.kernel.org/all/20241206112731.98244-1-peng.fan@oss.nxp.com/
> 
> I cherry-picked the two patches from linux-next:
> 
>   e1a875703470 ("pmdomain: imx-gpcv2: Suppress bind attrs")
>   afb2a86f002b ("pmdomain: imx8m[p]-blk-ctrl: Suppress bind attrs")
> 
> but I still have the same warnings:
> 
> [    5.427038] Device 'mediablk-mipi-csi2-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> [    6.464219] Device 'mediablk-mipi-dsi-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> [    6.752903] Device 'mediablk-mipi-csi2-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> [    7.303529] Device 'mediablk-mipi-dsi-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> [    8.006575] Device 'mediablk-mipi-csi2-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> [    8.598453] Device 'mediablk-mipi-dsi-1' does not have a release() function, it is broken and must be fixed. See Documentation/core-api/kobject.rst.
> 
> This is with 6.13-rc3 on a imx8mp.

As far as I can see this isn't emitted due to the blk-ctrl device
itself missing the release function, but from the pseudo devices used
by genpd to control the power of the secondary power domains.

I think this needs to be fixed in genpd itself. I'll take a look.

Regards,
Lucas