linux-kernel - Re: [PATCH] macintosh: declare ctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7j4sqkjgkj5wd2sraigedoppbojjvnptrajspl5bqehihlvzln@pc2zwgtnzdkm>
Date: Tue, 17 Dec 2024 06:42:55 -0300
From: "Ricardo B. Marliere" <rbm@...e.com>
To: Luis Felipe Hernandez <luis.hernandez093@...il.com>
Cc: Thomas Weißschuh <linux@...ssschuh.net>, 
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] macintosh: declare ctl_table as const

Hi!

On 16 Dec 24 22:20, Luis Felipe Hernandez wrote:
> Since commit 7abc9b53bd51 ("sysctl: allow registration of const struct
> ctl_table"), the sysctl registration API allows struct ctl_table variables
> to be placed into read-only memory.
> 
> mac_hid_files is registered as a sysctl table and should be treated as
> read-only. By declaring the mac_hid_files structure as const, we ensure
> that it cannot be accidentally modified at runtime. This change improves
> safety and aligns with the recommendation from commit 7abc9b53bd51
> ("sysctl: allow registration of const struct ctl_table").

No need to mention the commit twice :)

> 
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@...il.com>
> ---
> Suggested-by: Thomas Weißschuh <linux@...ssschuh.net>
> Suggested-by: Ricardo B. Marliere <rbm@...e.com>
> ---

What happened here? Signed-off-by should be last and without "---".

With those fixed:

Reviewed-by: Ricardo B. Marliere <rbm@...e.com>

Thank you,
-	Ricardo.


>  drivers/macintosh/mac_hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c
> index b461b1bed25b2df106ecf612b82efaedf69f62b0..369d72f59b3c10869bc914f31e7dcb73e029ef7f 100644
> --- a/drivers/macintosh/mac_hid.c
> +++ b/drivers/macintosh/mac_hid.c
> @@ -215,7 +215,7 @@ static int mac_hid_toggle_emumouse(const struct ctl_table *table, int write,
>  }
>  
>  /* file(s) in /proc/sys/dev/mac_hid */
> -static struct ctl_table mac_hid_files[] = {
> +static const struct ctl_table mac_hid_files[] = {
>  	{
>  		.procname	= "mouse_button_emulation",
>  		.data		= &mouse_emulate_buttons,
> 
> ---
> base-commit: e25c8d66f6786300b680866c0e0139981273feba
> change-id: 20241216-constify_sysctl_mac_hid-55886592c206
> 
> Best regards,
> -- 
> Luis Felipe Hernandez <luis.hernandez093@...il.com>
>