linux-kernel - Re: [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cb0d715-3756-4cef-bcc0-3bb550811c73@quicinc.com>
Date: Tue, 17 Dec 2024 17:54:57 +0800
From: Renjiang Han <quic_renjiang@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Stanimir Varbanov
	<stanimir.k.varbanov@...il.com>,
        Vikash Garodia <quic_vgarodia@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konradybcio@...nel.org>
CC: <linux-media@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Stanimir
 Varbanov" <stanimir.varbanov@...aro.org>
Subject: Re: [PATCH v5 3/4] arm64: dts: qcom: qcs615: add venus node


On 12/17/2024 5:38 PM, Bryan O'Donoghue wrote:
> On 17/12/2024 09:17, Renjiang Han wrote:
>> +
>> +            video-decoder {
>> +                compatible = "venus-decoder";
>> +            };
>> +
>> +            video-encoder {
>> +                compatible = "venus-encoder";
>> +            };
>
> I gave you feedback on this in v4.
>
> Could you please provide some commentary on why you're persisting with 
> this ?
>
> - Driver configuration should not live in dts
> - A patchset exists to mitigate this
> - If you don't want to use that series, what do you propose
>   to resolve this ?
>
> Please don't just ignore feedback, either act on it or add to your 
> commit log _why_ you didn't act on it.
>
> ---
> bod

  Thanks for your review. You pointed it out correctly. As replied in v4,

  I also think your change is a good change, but your change involves many

  platforms. I am not sure if other guys have comments and when it will

  pass the review. Currently, it only refers to SC7180 and falls back

  QCS615 to SC7180. I have verified it on both SC7180 and QCS615 platforms.

  I think when your change review passes, we only need to remove the

  video-decoder and video-encoder nodes in the device tree.

-- 
Best Regards,
Renjiang