linux-kernel - Re: [PATCH v2] net: Refine key_len calculations in rhashtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iL077dDhKwWA8Uqhco-uK=UdjZMy7+UABBT8h5Lq4UF+g@mail.gmail.com>
Date: Tue, 17 Dec 2024 11:19:02 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Liang Jie <buaajxlj@....com>
Cc: kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com, horms@...nel.org, 
	anthony.l.nguyen@...el.com, andrew+netdev@...n.ch, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Liang Jie <liangjie@...iang.com>
Subject: Re: [PATCH v2] net: Refine key_len calculations in rhashtable_params

On Tue, Dec 17, 2024 at 10:46 AM Liang Jie <buaajxlj@....com> wrote:
>
> From: Liang Jie <liangjie@...iang.com>
>
> This patch improves the calculation of key_len in the rhashtable_params
> structures across the net driver modules by replacing hardcoded sizes
> and previous calculations with appropriate macros like sizeof_field()
> and offsetofend().

Please wait at least 24 hours before sending new versions of a
networking patch,
because we are flooded with patches.

Documentation/process/maintainer-netdev.rst

Resending after review
~~~~~~~~~~~~~~~~~~~~~~

Allow at least 24 hours to pass between postings. This will ensure reviewers
from all geographical locations have a chance to chime in. Do not wait
too long (weeks) between postings either as it will make it harder for reviewers
to recall all the context.

Make sure you address all the feedback in your new posting. Do not post a new
version of the code if the discussion about the previous version is still
ongoing, unless directly instructed by a reviewer.

The new version of patches should be posted as a separate thread,
not as a reply to the previous posting. Change log should include a link
to the previous posting (see :ref:`Changes requested`).

Thank you.