linux-kernel - Re: [PATCH] nvme-pci: 512 byte aligned dma pool segment quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM5zL5pBfQQyRqjd5iV7ouTTii1sCD5fZJWE0zRkGkL18iz+-Q@mail.gmail.com>
Date: Tue, 17 Dec 2024 12:18:18 +0100
From: Paweł Anikiel <panikiel@...gle.com>
To: Robert Beckett <bob.beckett@...labora.com>
Cc: Keith Busch <kbusch@...nel.org>, axboe <axboe@...nel.dk>, hch <hch@....de>, 
	kernel <kernel@...labora.com>, linux-kernel <linux-kernel@...r.kernel.org>, 
	linux-nvme <linux-nvme@...ts.infradead.org>, sagi <sagi@...mberg.me>
Subject: Re: [PATCH] nvme-pci: 512 byte aligned dma pool segment quirk

On Wed, Dec 11, 2024 at 11:56 AM Robert Beckett
<bob.beckett@...labora.com> wrote:
>
>
>
>
>
>
>  ---- On Tue, 10 Dec 2024 21:36:55 +0000  Keith Busch  wrote ---
>  > On Mon, Dec 09, 2024 at 04:33:01PM +0100, Paweł Anikiel wrote:
>  > > On Mon, Dec 9, 2024 at 1:33 PM Robert Beckett bob.beckett@...labora.com> wrote:
>  > > > [...]
>  > > > I have no further updates on this. I have received no further info from the vendor.
>  > > > I think we can go ahead and use the alignment patch as is. The only outstanding question was whether it is an
>  > > > implicit last entry per page chain vs simple alisngment requirement. Either way, using the dmapool
>  > > > alignment fixes both of these potential causes, so we should just take it as is.
>  > > > If we ever get any better info and can do a more specific patch in future, we can rework it then.
>  > >
>  > > I think the 512 byte alignment fix is good. I tried coming up with
>  > > something more specific, but everything I could think of was either
>  > > too complicated or artificial.
>  > >
>  > > Regarding the question of whether this is an alignment requirement or
>  > > the last PRP entry issue, I strongly believe it's the latter. I have a
>  > > piece of code that clearly demonstrates the hardware bug when run on a
>  > > device with the nvme bridge. I would really appreciate it if this was
>  > > verified and my explanation was included in the patch.
>  >
>  > I've pushed this to nvme-6.13 with an updated commit message here:
>  >
>  >   https://git.infradead.org/?p=nvme.git;a=commitdiff;h=ccd84b8d6f4a60626dacb933b5d56dadca75c0ca
>
> lgtm. Thanks!

Looks good to me as well. Thank you!