linux-kernel - Re: [PATCH] docs: mm: fix the incorrect 'FileHugeMapped' field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd96e6d4-b8fe-4360-b6eb-f6375df9eaf2@redhat.com>
Date: Tue, 17 Dec 2024 12:59:04 +0100
From: David Hildenbrand <david@...hat.com>
To: Baolin Wang <baolin.wang@...ux.alibaba.com>, akpm@...ux-foundation.org
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: mm: fix the incorrect 'FileHugeMapped' field

On 17.12.24 09:55, Baolin Wang wrote:
> The '/proc/PID/smaps' does not have the 'FileHugeMapped' field to count the
> file transparent huge pages, instead, the 'FilePmdMapped' field should be
> used. Fix it.
> 
> Signed-off-by: Baolin Wang <baolin.wang@...ux.alibaba.com>
> ---
>   Documentation/admin-guide/mm/transhuge.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/mm/transhuge.rst b/Documentation/admin-guide/mm/transhuge.rst
> index 156a03af0a88..dff8d5985f0f 100644
> --- a/Documentation/admin-guide/mm/transhuge.rst
> +++ b/Documentation/admin-guide/mm/transhuge.rst
> @@ -466,7 +466,7 @@ AnonHugePmdMapped).
>   The number of file transparent huge pages mapped to userspace is available
>   by reading ShmemPmdMapped and ShmemHugePages fields in ``/proc/meminfo``.
>   To identify what applications are mapping file transparent huge pages, it
> -is necessary to read ``/proc/PID/smaps`` and count the FileHugeMapped fields
> +is necessary to read ``/proc/PID/smaps`` and count the FilePmdMapped fields
>   for each mapping.

We should probably change the above to clarify that this is all about 
PMD sized things.

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb