linux-kernel - Re: [PATCH net-next 0/2] net: dsa: microchip: Add of config for LED mode for ksz87xx and ksz88x3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217133402.GA1420212-robh@kernel.org>
Date: Tue, 17 Dec 2024 07:34:02 -0600
From: Rob Herring <robh@...nel.org>
To: Marek Vasut <marex@...x.de>
Cc: Andrew Lunn <andrew@...n.ch>, Fedor Ross <fedor.ross@....com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	UNGLinuxDriver@...rochip.com, Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Tristram Ha <tristram.ha@...rochip.com>
Subject: Re: [PATCH net-next 0/2] net: dsa: microchip: Add of config for LED
 mode for ksz87xx and ksz88x3

On Mon, Dec 09, 2024 at 09:26:33PM +0100, Marek Vasut wrote:
> On 12/9/24 7:22 PM, Andrew Lunn wrote:
> > On Mon, Dec 09, 2024 at 06:58:50PM +0100, Fedor Ross wrote:
> > > Add support for the led-mode property for the following PHYs which have
> > > a single LED mode configuration value.
> > > 
> > > KSZ8765, KSZ8794 and KSZ8795 use register 0x0b bits 5,4 to control the
> > > LED configuration.
> > > 
> > > KSZ8863 and KSZ8873 use register 0xc3 bits 5,4 to control the LED
> > > configuration.
> > 
> > PHY and MAC LEDs should be configured via /sys/class/leds. Please take
> > a look at how the Marvell PHY and DSA driver, qca8k driver etc do
> > LEDs.
> According to KSZ8794 datasheet, this register 0xb is Global Control:
> 
> Register 11 (0x0B): Global Control 9
> 
> So this does not seems like per-port LED control, but rather some global
> control for all LEDs on all ports on the chip ?

Still should be able to use the standard binding and sysfs controls. The 
driver just has to reject invalid combinations.

Rob