linux-kernel - Re: [linux-next:master 2636/3192] drivers/fpga/dfl.c:154: warning: Function parameter or struct member 'fdata' not described in 'dfl_fpga_port_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZAQHTiJm59ZK0GXn@yilunxu-OptiPlex-7050>
Date: Sun, 5 Mar 2023 11:06:54 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: "Colberg, Peter" <peter.colberg@...el.com>
Cc: "linux-fpga@...r.kernel.org" <linux-fpga@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
	"matthew.gerlach@...ux.intel.com" <matthew.gerlach@...ux.intel.com>,
	"basheer.ahmed.muddebihal@...ux.intel.com" <basheer.ahmed.muddebihal@...ux.intel.com>
Subject: Re: [linux-next:master 2636/3192] drivers/fpga/dfl.c:154: warning:
 Function parameter or struct member 'fdata' not described in
 'dfl_fpga_port_ops_get'

> These warnings may be resolved by amending commit a25cd37037c8 ("fpga:
> dfl: refactor internal DFL APIs to take/return feature device data").
> 
> --- a/drivers/fpga/dfl.c
> +++ b/drivers/fpga/dfl.c
> @@ -145,7 +145,7 @@ static LIST_HEAD(dfl_port_ops_list);
>  
>  /**
>   * dfl_fpga_port_ops_get - get matched port ops from the global list
> - * @pdata: platform data to match with associated port ops.
> + * @fdata: feature dev data to match with associated port ops.
>   * Return: matched port ops on success, NULL otherwise.
>   *
>   * Please note that must dfl_fpga_port_ops_put after use the port_ops.
> @@ -211,7 +211,7 @@ EXPORT_SYMBOL_GPL(dfl_fpga_port_ops_del);
>  
>  /**
>   * dfl_fpga_check_port_id - check the port id
> - * @pdata: port platform data.
> + * @fdata: port feature dev data.
>   * @pport_id: port id to compare.
>   *
>   * Return: 1 if port device matches with given port id, otherwise 0.

I've fixed, ran scripts/kernel-doc and pushed for all 3 patches.

Thanks,
Yilun