linux-kernel - Re: [PATCH V3] scsi: ufs: qcom: Enable UFS Shared ICE Feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0f4836c6-9a1d-4798-af1c-b3a01d2328d5@quicinc.com>
Date: Wed, 18 Dec 2024 20:48:36 +0530
From: Ram Kumar Dwivedi <quic_rdwivedi@...cinc.com>
To: Bart Van Assche <bvanassche@....org>, <manivannan.sadhasivam@...aro.org>,
        <James.Bottomley@...senPartnership.com>, <martin.petersen@...cle.com>,
        <andersson@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Naveen Kumar Goud Arepalli
	<quic_narepall@...cinc.com>,
        Nitin Rawat <quic_nitirawa@...cinc.com>
Subject: Re: [PATCH V3] scsi: ufs: qcom: Enable UFS Shared ICE Feature



On 17-Dec-24 9:16 PM, Bart Van Assche wrote:
> On 12/17/24 6:40 AM, Ram Kumar Dwivedi wrote:
>> +    unsigned int val[4] = { NUM_RX_R1W0, NUM_TX_R0W1, NUM_RX_R1W1, NUM_TX_R1W1 };
>> +    unsigned int config;
>> +
>> +    if (!is_ice_config_supported(host))
>> +        return;
>> +
>> +    config = val[0] | (val[1] << 8) | (val[2] << 16) | (val[3] << 24);
> 
> Has it been considered to change the data type of val[] from unsigned int into u8 or uint8_t? That would allow to use get_unaligned_le32() instead of the above bit-shift expression. Additionally, why has 'config' been declared as 'int' instead of 'u32'?
>
Hi Bart, 
Thanks for review. We have addressed your comment in latest patchset.

Thanks,
Ram.

> Thanks,
> 
> Bart.