linux-kernel - Re: [PATCH v5 2/7] x86/mce/threshold: Remove the redundant this_cpu_dec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218153656.GB1155365@yaz-khff2.amd.com>
Date: Wed, 18 Dec 2024 10:36:56 -0500
From: Yazen Ghannam <yazen.ghannam@....com>
To: Qiuxu Zhuo <qiuxu.zhuo@...el.com>
Cc: bp@...en8.de, tony.luck@...el.com, tglx@...utronix.de,
	dave.hansen@...ux.intel.com, mingo@...hat.com, hpa@...or.com,
	sohil.mehta@...el.com, nik.borisov@...e.com, x86@...nel.org,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/7] x86/mce/threshold: Remove the redundant
 this_cpu_dec_return()

On Thu, Dec 12, 2024 at 10:00:58PM +0800, Qiuxu Zhuo wrote:
> The 'storm' variable points to this_cpu_ptr(&storm_desc). Access the
> 'stormy_bank_count' field through the 'storm' to avoid calling
> this_cpu_*() on the same per-CPU variable twice.
> 
> This minor optimization reduces the text size by 16 bytes.
> 
>   $ size threshold.o.*
>      text	   data	    bss	    dec	    hex	filename
>      1395	   1664	      0	   3059	    bf3	threshold.o.old
>      1379	   1664	      0	   3043	    be3	threshold.o.new
> 
> No functional changes intended.
> 
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Reviewed-by: Nikolay Borisov <nik.borisov@...e.com>
> Reviewed-by: Sohil Mehta <sohil.mehta@...el.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@...el.com>

Reviewed-by: Yazen Ghannam <yazen.ghannam@....com>

Thanks,
Yazen