linux-kernel - Re: lock in vsprintf(): was: Re: [PATCH] of: Add printf '%pOFm' for generating modalias

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218113156.30a50a07@gandalf.local.home>
Date: Wed, 18 Dec 2024 11:31:56 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Petr Mladek <pmladek@...e.com>
Cc: "Rob Herring (Arm)" <robh@...nel.org>, Linus Torvalds
 <torvalds@...ux-foundation.org>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Rasmus Villemoes
 <linux@...musvillemoes.dk>, Sergey Senozhatsky <senozhatsky@...omium.org>,
 Jonathan Corbet <corbet@....net>, Saravana Kannan <saravanak@...gle.com>,
 Andrew Morton <akpm@...ux-foundation.org>, John Ogness
 <john.ogness@...utronix.de>, Peter Zijlstra <peterz@...radead.org>, Thomas
 Gleixner <tglx@...utronix.de>, Zijun Hu <quic_zijuhu@...cinc.com>,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: lock in vsprintf(): was: Re: [PATCH] of: Add printf '%pOFm' for
 generating modalias

On Wed, 18 Dec 2024 13:27:39 +0100
Petr Mladek <pmladek@...e.com> wrote:

> But this would happen only when the last reference is released
> when formatting the string which is kind of corner case.
> 
> As I said, I think that taking lock in vsprintf() formats is highly
> unexpected and thus a way to hell.
> 
> What do others think, please?

We already can take locks from printk formats.

  https://lore.kernel.org/all/20241120102602.3e17f2d5@gandalf.local.home/

At least when SELinux is enabled.

But that may be an SELinux issue and not a printk one.

-- Steve