linux-kernel - Re: [PATCH v4 2/8] blk-cgroup: Fix class @block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z2L6xk1qD-fqUz-J@slm.duckdns.org>
Date: Wed, 18 Dec 2024 06:39:34 -1000
From: Tejun Heo <tj@...nel.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Josef Bacik <josef@...icpanda.com>, Jens Axboe <axboe@...nel.dk>,
	Boris Burkov <boris@....io>, Davidlohr Bueso <dave@...olabs.net>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-block@...r.kernel.org, linux-cxl@...r.kernel.org,
	Zijun Hu <quic_zijuhu@...cinc.com>,
	Michal Koutný <mkoutny@...e.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH v4 2/8] blk-cgroup: Fix class @block_class's subsystem
 refcount leakage

On Wed, Dec 18, 2024 at 08:01:32AM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
> 
> blkcg_fill_root_iostats() iterates over @block_class's devices by
> class_dev_iter_(init|next)(), but does not end iterating with
> class_dev_iter_exit(), so causes the class's subsystem refcount leakage.
> 
> Fix by ending the iterating with class_dev_iter_exit().
> 
> Fixes: ef45fe470e1e ("blk-cgroup: show global disk stats in root cgroup io.stat")
> Reviewed-by: Michal Koutný <mkoutny@...e.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: stable@...r.kernel.org
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun