linux-kernel - Re: [PATCH v2 2/2] kbuild: Add option to fail build on vmlinux objtool issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241218190406.gbemqsbf3rxtione@jpoimboe>
Date: Wed, 18 Dec 2024 11:04:06 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Peter Zijlstra <peterz@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Masahiro Yamada <masahiroy@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nicolas Schier <nicolas@...sle.eu>, linux-kernel@...r.kernel.org,
	linux-kbuild@...r.kernel.org
Subject: Re: [PATCH v2 2/2] kbuild: Add option to fail build on vmlinux
 objtool issues

On Wed, Dec 18, 2024 at 02:58:56PM +0000, Brendan Jackman wrote:
> NOINSTR_VALIDATION is pretty helpful for detecting bugs, it would be
> helpful for the build to fail when those bugs arise.
> 
> If necessary it would be possible to enable this for individual
> warnings, it seems unlikely there's a use-case for that though. So
> for now just add a global setting.
> 
> Signed-off-by: Brendan Jackman <jackmanb@...gle.com>

The patch looks good to me, though the subject and commit log still need
to be updated.  It's no longer specific to vmlinux or
NOINSTR_VALIDATION.  And the justification is similar to what I
mentioned before: objtool warnings (even seemingly "harmless" ones)
often indicate serious bugs which can break the kernel.

-- 
Josh