linux-kernel - Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241217190359.6958ea4f@kernel.org>
Date: Tue, 17 Dec 2024 19:03:59 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Roopa Prabhu <roopa@...dia.com>, Nikolay Aleksandrov
 <razor@...ckwall.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Kalle Valo
 <kvalo@...nel.org>, Manish Chopra <manishc@...vell.com>, Rahul Verma
 <rahulv@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Andrew Lunn
 <andrew+netdev@...n.ch>, Shahed Shaikh <shshaikh@...vell.com>,
 bridge@...ts.linux.dev, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'

On Mon, 16 Dec 2024 12:30:12 +0100 Thomas Weißschuh wrote:
> -	.read = qlcnic_sysfs_read_pci_config,
> -	.write = NULL,
> +	.read_new = qlcnic_sysfs_read_pci_config,
> +	.write_new = NULL,

Please delete the NULL assignment instead.